fix: declare lxml as a runtime dependency (v1.6.1)#84
Open
AleksandrSl wants to merge 2 commits into
Open
Conversation
contentstack_utils.utils imports lxml.etree at module load time, but install_requires has been empty since initial release. Declare lxml with environment markers: >=6.1.0 on Python 3.8+ (aligned with requirements.txt), >=4.9.0,<5 on 3.6–3.7. Co-authored-by: Cursor <cursoragent@cursor.com>
AleksandrSl
commented
Jul 9, 2026
| install_requires=[ | ||
|
|
||
| # lxml 6.x requires Python 3.8+; keep 4.x for 3.6–3.7 (python_requires>=3.6). | ||
| "lxml>=4.9.0,<5; python_version<'3.8'", |
Author
There was a problem hiding this comment.
It may make sense to drop support for python <3.9 already since even 3.10 is eol this October https://devguide.python.org/versions/
But that would be a major release
AleksandrSl
commented
Jul 9, 2026
Author
There was a problem hiding this comment.
The development branch is not up to the latest main, so this change is propagated, but is not mine
AleksandrSl
commented
Jul 9, 2026
| __author__ = 'contentstack' | ||
| __status__ = 'debug' | ||
| __version__ = '1.6.0' | ||
| __version__ = '1.6.1' |
Author
There was a problem hiding this comment.
Actually I just though that patch version bump is not ideal, and major release is better, because thought people had to install lxml already they could install any version of it, since the library didn't restrict it. Now it's restricted, so people may get conflicts? Shouldn't be that bad, but I leave the decision on you
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
contentstack_utils.utils imports lxml.etree at module load time, but install_requires has been empty since initial release. Declare lxml with environment markers: >=6.1.0 on Python 3.8+ (aligned with requirements.txt),